search

Crunch-io / rcrunch

R package for interacting with the Crunch API
https://crunch.io/r/crunch/
GNU Lesser General Public License v3.0
9 stars 15 forks source link

Implement subtotal differences in rcrunch #559

Closed gergness closed 3 years ago

gergness commented 3 years ago

Simple implementation of subtotal differences in rcrunch. Can create them, and see their results in a cube, correctly for counts & table proportions, but I have not handled the row/column proportion or bases special case logic that we did in cr.cube.

This PR was done in a way to minimize changes. I think a restructuring of insertions should happen when we return to this code for MR insertions.

codecov[bot] commented 3 years ago

Codecov Report

Merging #559 (210f98d) into master (bda1b53) will increase coverage by 0.06%. The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   90.50%   90.56%   +0.06%     
==========================================
  Files         128      128              
  Lines        8032     8133     +101     
==========================================
+ Hits         7269     7366      +97     
- Misses        763      767       +4
Impacted Files Coverage Δ
R/AllGenerics.R 92.30% <50.00%> (-0.67%) :arrow_down:
R/insertions.R 97.14% <82.35%> (-2.86%) :arrow_down:
R/AllClasses.R 100.00% <100.00%> (ø)
R/cube-transforms.R 95.78% <100.00%> (+0.07%) :arrow_up:
R/show.R 88.21% <100.00%> (+0.34%) :arrow_up:
R/subtotals-and-headings.R 96.07% <100.00%> (+0.42%) :arrow_up:
R/search.R 100.00% <0.00%> (ø)
R/as-vector.R 94.33% <0.00%> (ø)
R/variables.R 100.00% <0.00%> (ø)
R/make-array.R 84.66% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bda1b53...210f98d. Read the comment docs.