search

Crunch-io / rcrunch

R package for interacting with the Crunch API
https://crunch.io/r/crunch/
GNU Lesser General Public License v3.0
9 stars 15 forks source link

[#178181135]: better check for empty values in catalog #573

Closed gergness closed 3 years ago

gergness commented 3 years ago

Fixes a bug where we couldn't print a deck catalog because it's dashboard key was an empty JSON dict.

x <- jsonlite::fromJSON("{}")

identical(x, list())
#> FALSE

identical(unname(x), list())
#> TRUE
codecov[bot] commented 3 years ago

Codecov Report

Merging #573 (8ec04a2) into master (492bea4) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files         128      128           
  Lines        8166     8166           
=======================================
  Hits         7398     7398           
  Misses        768      768
Impacted Files Coverage Δ
R/shoji-catalog.R 93.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 492bea4...8ec04a2. Read the comment docs.