Closed gergness closed 3 years ago
Merging #578 (e2c52e7) into master (bfc44f5) will increase coverage by
0.00%
. The diff coverage is100.00%
.:exclamation: Current head e2c52e7 differs from pull request most recent head 486505a. Consider uploading reports for the commit 486505a to get more accurate results
@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 128 128
Lines 8179 8183 +4
=======================================
+ Hits 7412 7416 +4
Misses 767 767
Impacted Files | Coverage Δ | |
---|---|---|
R/cube-result.R | 97.73% <ø> (ø) |
|
R/api.R | 93.18% <100.00%> (+0.15%) |
:arrow_up: |
R/misc.R | 98.93% <100.00%> (+0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bfc44f5...486505a. Read the comment docs.
A lazy way to avoid the warning introduced in R 4.1.
This
I()
is called when trying to check if the new categories are the same as the existing ones so that it can avoid a no-opPATCH
. However, while tracking this warning message, I noticed that updating categories like this does not actually work, becauseslot(x, "body")[[i]]
wherex
is aVariableEntity
andi
is"categories"
is a regular R list (has not yet been converted to aCategories
S4 object), butvalue
is a trueCategories
S4 object.I did a little bit of work trying to make this better, but it doesn't feel worth it to pursue further. I'll link to this with an issue to capture the work I did.