search

Crunch-io / rcrunch

R package for interacting with the Crunch API
https://crunch.io/r/crunch/
GNU Lesser General Public License v3.0
9 stars 15 forks source link

Fix partial argument match in `getDatasetVariables()` #625

Closed rossellhayes closed 1 year ago

rossellhayes commented 1 year ago

Fixes the call to httpcache::buildCacheKey() in getDatasetVariables(), getDatasetHiddenVariables() and getDatasetPrivateVariables(). The extras argument is now fully spelled out to avoid a partial argument match. With this fix, interactions with a dataset through crunch with the option warnPartialMatchArgs set to TRUE no longer trigger a warning message.

options(warnPartialMatchArgs = TRUE)

library(crunch)
set_crunch_opts("crunch.api" = "https://app.crunch.io/api/")
library(httptest)
start_vignette("crunch")
ds <- newDataset(SO_survey, name="Stack Overflow Developer Survey 2017")
dim(ds)
#> [1] 1634   23

Created on 2023-07-19 with reprex v2.0.2

Closes #624.

gergness commented 1 year ago

Thanks! Need to figure out why the github actions are failing, but maybe I can add that setting so that we prevent regressions.

rossellhayes commented 1 year ago

@gergness It looks like the issue is coming from using an outdated version of the R-CMD-check action. Running usethis::use_github_action("check-full") should update the workflow and hopefully get it working again 🤞