Open chrisBrookes93 opened 1 year ago
+1 in pinning to the latest version
I believe this PR would resolve this issue - https://github.com/Crunch-io/scrunch/pull/439
@andrepedroso for our use case we need requests>=2.25.0. The MR you mention only bumps it to 2.20.0, which is still an old version released more than 4 years ago
You're entirely correct @chrisBrookes93 , thank you for the correction :) my bad
The latest Scrunch version 0.15.3 is pinned on requests==2.27.0 which is the last version to officially support Python2.7 which we still need to support for certain customers. We also need Scrunch+Pycrunch to work with Python3.6, so that may need pinning another particular version of requests for 3.6 only and a third more recent version for higher Python versions.
I don't think that the requests API that pycrunch uses has changed much, but would need to test thoroughly for Pycrunch.
I'm not able to upgrade to the latest version of scrunch in a project where we make use of it because of a dependency version conflict:
This package pins to a version of requests that is 5 years old -
requests==2.18.4
was released Aug 2017.Can I suggest we either:
requests
requests>=2.18.4,<3
)As this is a package often incorporated into other projects, I'd suggest pinning to an exact version is constraining users.