search

Crunch-io / scrunch

Pythonic scripting library for cleaning data in Crunch
GNU Lesser General Public License v3.0
5 stars 7 forks source link

Making scrunch compatible with Python 3.11 #450

Closed shaikh-ma closed 9 months ago

shaikh-ma commented 10 months ago

As discussed in the issues section of the scrunch repository here, this Pull Request attempts to make scrunch compatible with the Python version 3.11.

The adjustments are made only in the modules, dataset.py, order.py & expressions.py.

These include version specific checks for importing methods from the collection module and accessing of values of the ast.Subscript object.

Python version Test Result
2.7 image
3.6 image
3.11 image
alexbuchhammer commented 10 months ago

Thanks @shaikh-ma!

shaikh-ma commented 10 months ago

Hi @jjdelc,

As discussed, here's the Pull Request which supports 3.6 & 3.11.

Please could verify it on your end and let us know if it's good to be merged. :)

jamesrkg commented 9 months ago

Hi @jjdelc,

Can you please let us know how/when this PR can progress? This is a significant impediment to our efforts to update our code base at the moment. If there is anything we can do to further help resolve the PR, please just let us know.

Cheers, Jamie

jjdelc commented 9 months ago

I'll look at this now

jjdelc commented 9 months ago

Thanks @shaikh-ma !!

shaikh-ma commented 9 months ago

Thank you too @jjdelc !!