search

Crunch-io / scrunch

Pythonic scripting library for cleaning data in Crunch
GNU Lesser General Public License v3.0
5 stars 7 forks source link

add tests on filter with datetime variables #455

Closed aless10 closed 3 months ago

aless10 commented 5 months ago

Following slack conversation: https://crunch-io.slack.com/archives/C072AKYD58X/p1717521227887949

aless10 commented 5 months ago

@jjdelc I'm also having issue installing the project locally, because the pycrunch dependency is 0.5.5 from the setup.py file while in the requirements it will get the latest one. Do we need to update the pycrunch version also from the setup.py file?

aless10 commented 5 months ago

Also, I made some changes on the github action file to have a green CI for py2.7, I see now that there is already a PR for this https://github.com/Crunch-io/scrunch/pull/445/files. Let me know if you want me to rebase from that one

aless10 commented 4 months ago

@jjdelc I run the integration tests against alpha which has the code from the fix https://github.com/Crunch-io/zoom/pull/8913 The tests pass. So that is a good news