Crunchy-DL / Crunchy-Downloader

A simple crunchyroll downloader that allows you to download your favorite series and episodes directly from Crunchyroll
MIT License
126 stars 13 forks source link

Unable to download files with very long names. #140

Closed NeonShogun404 closed 2 weeks ago

NeonShogun404 commented 2 weeks ago

Hello, first of all, congratulations to the creator for the program. It's incredible how well it works. Now the problem I've encountered: I'm downloading the anime "The Family Circumstances of the Irregular Witch". Episode 11 can't be downloaded with the configuration I have for the current renaming, that is: ${seriesTitle}\S${season}\S${season}E${episode} - ${title} [${height}p] [${dubs}]

image

I know the error is that the title is too long, because I've tried with this configuration: ${seriesTitle}\S${season}\S${season}E${episode} - [${height}p] [${dubs}] and the episode has been downloaded.

image

I would like there to be an option in the program's configuration that allows setting a maximum number of characters in the file title. This would help with animes like this that have very long names. Thanks.

Elwador commented 2 weeks ago

i had no problem downloading the episode with ${seriesTitle}\\S${season}\\S${season}E${episode} - ${title} [${height}p] [${dubs}] but you are right there is a limit how long the file name can be can you please test it with v1.5.36.1

NeonShogun404 commented 2 weeks ago

I have tried on 2 PCs. On the first one it still won't let me download the file. In other words: it downloads, decrypts and when it is muxed it disappears. I noticed that on this PC the language in which the title appears is English (and the title is very long).

image

image

image

On the other PC it did let me download it in one go. In this case the title appears in Spanish and is much shorter in terms of characters.

image

image

If you ask me, I don't know why the titles appear in English on one PC and in Spanish on the other.

Elwador commented 2 weeks ago

the different language is probably that on one pc you have changed the history language

the v1.5.36.1 should shorten the name to a length that should work fine

i updated the v1.5.36.1 with some debug messages maybe try to enable the log mode and see if it says that the filename is to long

i also tried it with the english title and even with the v1.5.36 it works 😆 so kind of strange that it doesn't work for you

Edit: Just tried it on a win 10 pc and there it fails in the same way you described...

Edit 2: ok it's a problem with file path length i have long file paths enabled on my main pc so that's why it works fine for me

Elwador commented 2 weeks ago

i updated the v1.5.36.1 release - it now also works when i disable windows long file paths

NeonShogun404 commented 2 weeks ago

I tried again and this time I was able to download the episode with the title in English.

image

By the way, the language issue was because of what you mentioned (I had Spanish assigned in the history of the other PC).

Thank you very much.