search

CrunchyBagel / TracePrivately

A privacy-focused app using Apple's soon-to-be-released contact tracing framework.
MIT License
351 stars 27 forks source link

Updated main storyboard to allow scrolling #33

Closed kevinrmblr closed 4 years ago

kevinrmblr commented 4 years ago

On smaller devices, the stackview became too large, causing layout constraint errors. Moving the view into a scrollview allows the stack to grow and fixes the layout on smaller devices.

HendX commented 4 years ago

Thanks @kevinrmblr! Agreed this is important - I just need to test locally before merging, since I'm hoping to have no scrolling if possible so important buttons aren't hidden.

HendX commented 4 years ago

@kevinrmblr I'm having two issues with this PR:

1) The padding is lost on the main stack view. Setting the "equal width" constant to -40 and the leading insead of the stack view to 20 fixes this

2) I just tested on iPhone SE 2nd Gen - it allows me to scroll down but then not scroll back up again. On a smaller device like SE 1st Gen this isn't a problem.

HendX commented 4 years ago

I've implemented this now - I couldn't figure out how to fix the conflicts for merging so reimplemented it manually. Apologies about this. Thanks for the submission.