CrunchyBagel / TracePrivately

A privacy-focused app using Apple's soon-to-be-released contact tracing framework.
MIT License
350 stars 27 forks source link

Feat/submit fields #44

Closed HendX closed 4 years ago

HendX commented 4 years ago

@tatey Sorry to keep hammering you with changes but I'm merging the planned changes for the OpenAPI spec. The 3 changes are:

tatey commented 4 years ago

I've now specified a 400 response in each of the endpoints

Captured in https://github.com/tatey/trace_privately/issues/22.

Technically the server can respond with 429, 500, and 503 too. In the case of 429 you should not retry. In the case of 500 and 503 it's probably OK to retry, but if you keep getting it, it's futile because there's a problem on the server or between the client and the server.

The submit callback can now accept arbitrary form data, as described in the SubmitConfig.plist file in the iOS app. If you don't implement this then it shouldn't break anything, you just won't get all of the data

Yes, I would expect it to be silently ignored at the moment. I've captured this in https://github.com/tatey/trace_privately/issues/21.

I'm also moving towards using the MessagePack data as a response option in infected. That's in a different branch to this though.

Captured in https://github.com/tatey/trace_privately/issues/23.


Feel free to sub if you want to stay across them.