CrunchyData / crunchy-containers

Containers for Managing PostgreSQL on Kubernetes by Crunchy Data
https://www.crunchydata.com/
Apache License 2.0
1.02k stars 327 forks source link

Update start.sh #1502

Open David-Angel opened 1 year ago

David-Angel commented 1 year ago

This is a solution for this issue: https://github.com/CrunchyData/postgres-operator/issues/3477

It turns off hugepages in the "postgresql.conf.sample" sample file.

Checklist:

Type of Changes:

What is the current behavior? (link to any open issues here) https://github.com/CrunchyData/postgres-operator/issues/3477

What is the new behavior (if this is a feature change)? The new behavior would not crash the pod when initdb is called.

Other information:

linouxis9 commented 1 year ago

This issue has been mentionned many times as shown here: https://github.com/CrunchyData/postgres-operator/issues/3477#issuecomment-1397765316 It would be amazing to finally have a fix be merged, thank you @David-Angel

David-Angel commented 1 year ago

@linouxis9 thanks for your assistance.
I was working too late and mistakenly closed this.

This solution will work if crunchydata accepts it.

David-Angel commented 1 year ago

Another solution to this is to create a custom docker build that replaces the sample config file. Be sure to set the user "USER root" before the change and "USER 26" after.

This PR is still the best solution once accepted.

David-Angel commented 1 year ago

This may be resolved in the latest build by Crunchydata as they updated their documentation to say it is now disabled by default. https://access.crunchydata.com/documentation/postgres-operator/latest/guides/huge-pages/

I'll verify and close out the defect if not commented on by Crunchydata