CrunchyData / crunchy-containers

Containers for Managing PostgreSQL on Kubernetes by Crunchy Data
https://www.crunchydata.com/
Apache License 2.0
1.01k stars 329 forks source link

split out crunchy-postgres-gis from crunchy-postgres #61

Closed jmccormick2001 closed 7 years ago

jmccormick2001 commented 7 years ago

probably a good time to split out the GIS packages into a separate container when users need a postgres+postgis container....the postgres-gis would inherit from the postgres container to avoid duplication...

pvacca commented 7 years ago

Sure. I've got a minor refactor for 9.6 just waiting to check in. Can split postgis out, too. Just as soon as the upgrade demo script runs beginning to end... Github doesn't seem to be letting me assign to myself for some reason.

jmccormick2001 commented 7 years ago

lets do a separate PR for the 9.6 support, then another PR for the upgrade container, if both of those get done, reviewed, merged, I'd like to add those into 1.2.6 next week. After all that is done, we can address this one, probably for the 1.2.7 release.

thesteve0 commented 7 years ago

Are you going to do that with other extensions as well?

If I understand right this will produce a new container in DockerHub right?

On Fri, Dec 16, 2016 at 12:02 PM, Jeff McCormick notifications@github.com wrote:

lets do a separate PR for the 9.6 support, then another PR for the upgrade container, if both of those get done, reviewed, merged, I'd like to add those into 1.2.6 next week. After all that is done, we can address this one, probably for the 1.2.7 release.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CrunchyData/crunchy-containers/issues/61#issuecomment-267683406, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVsw-4dK7WXwk4A43tUIuqytbDS6uJlks5rIu49gaJpZM4LPZRt .

jmccormick2001 commented 7 years ago

yep, this would move the postgis+pgrouting extensions which are quite heavy into a new crunchy-postgres-gis container...the other extensions like pgaudit and pg_stat_statements and backrest are smaller, simpler, and not GIS related so I might leave them in the base pg container for the first cut. This split would allow us to greatly extend the postgres-gis container in the future too.

thesteve0 commented 7 years ago

Sounds good. What about a more generic way to load other extensions?

http://pgxn.org/

https://github.com/dhamaniasad/awesome-postgres#extensions

Would S2I help with that?

On Fri, Dec 16, 2016 at 12:22 PM, Jeff McCormick notifications@github.com wrote:

yep, this would move the postgis+pgrouting extensions which are quite heavy into a new crunchy-postgres-gis container...the other extensions like pgaudit and pg_stat_statements and backrest are smaller, simpler, and not GIS related so I might leave them in the base pg container for the first cut. This split would allow us to greatly extend the postgres-gis container in the future too.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CrunchyData/crunchy-containers/issues/61#issuecomment-267687353, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVsw-4MkUcNNr1yxoQCFIda6TnmSItQks5rIvMYgaJpZM4LPZRt .

jmccormick2001 commented 7 years ago

maybe, I definitely would like a smarter way to add extensions rather than having to add the packages directly within the Dockerfile, I'll take a look at these other techniques.

pvacca commented 7 years ago

I actually have an idea on making the extensions more configurable at build time with a docker in docker technique. Let's get the postgis extension split out as discussed, and I can explain this in more detail after the coming release is tested and ready to go.

On Dec 16, 2016 2:40 PM, "Jeff McCormick" notifications@github.com wrote:

maybe, I definitely would like a smarter way to add extensions rather than having to add the packages directly within the Dockerfile, I'll take a look at these other techniques.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CrunchyData/crunchy-containers/issues/61#issuecomment-267690716, or mute the thread https://github.com/notifications/unsubscribe-auth/ABa5IU7g8ht2v8QrITrWm4wFzpJqJEjgks5rIvcjgaJpZM4LPZRt .

jmccormick2001 commented 7 years ago

merged in new dockerfiles for a new container, crunchy-postgres-gis, it is identical to crunchy-postgres except it includes the PostGIS and pgrouting packages...after this, the crunchy-postgres image no longer includes the GIS packages. This will land in the upcoming 1.2.7 release.