search

CrunchyData / crunchy-katacoda

Other
10 stars 31 forks source link

Redesign of Katacoda Learning Portal #77

Closed xenophenes closed 4 years ago

xenophenes commented 4 years ago

Additional testing is needed before merging.

One follow-up commit may appear later today that has additional tweaks after a thorough review.

At the time of this Draft PR, screenshots across the site look like the following:

Screenshot from 2019-12-20 14-45-41 Screenshot from 2019-12-20 14-45-29 Screenshot from 2019-12-20 14-45-18 Screenshot from 2019-12-20 14-45-12 Screenshot from 2019-12-20 12-34-45 Screenshot from 2019-12-20 12-34-31 Screenshot from 2019-12-20 12-34-26

thesteve0 commented 4 years ago

So I should not merge for now?

On Fri, Dec 20, 2019 at 2:50 PM Sarah Conway Schnurr < notifications@github.com> wrote:

Additional testing is needed before merging.

One follow-up commit may appear later today that has additional tweaks after a thorough review.

You can view, comment on, or merge this pull request online at:

https://github.com/CrunchyData/crunchy-katacoda/pull/77 Commit Summary

  • Initial frontend redesign
  • Initial separation of CSS assets
  • Wrap up overhaul of Katacoda style overrides

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CrunchyData/crunchy-katacoda/pull/77?email_source=notifications&email_token=AAKWZQ2YL7UOU32BBF7DQ4TQZVD5BA5CNFSM4J6DRB62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICCSRSQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWZQYCMP7BGMXHAN6J6ULQZVD5BANCNFSM4J6DRB6Q .

xenophenes commented 4 years ago

@thesteve0 We are good to go!

thesteve0 commented 4 years ago

@BenHall @gsoria can you please merge build and let us know when we can see it on beta.katacoda.com?