Map view: ensure data extent is set on start

CrunchyData / pg_featureserv

Lightweight RESTful Geospatial Feature Server for PostGIS in Go

Apache License 2.0

459 stars 91 forks source link

Closed JakobMiksch closed 1 week ago

JakobMiksch commented 1 year ago

before when the map was loaded the extent was initially at null island and jumped afterwards to the extent of the data. see GIFs below. I find this a bit distracting and confusing.
this PR ensures the map has the data extent directly at the start by loading the data first and initializing the map afterwards
for loading the data the very ancient XMLHttpRequest was chosen to guarantee maximum browser compatibility. However we could also use the more modern fetch approach.

before:

ol-before

after:

ol_after

dr-jts commented 1 year ago

What if the data takes a long time to load, or errors out?

JakobMiksch commented 1 year ago

loading the in-built example with 10000 points loads in reasonable time (a few seconds):

Peek 2023-10-21 16-02

when I add a 5 second timeout in the JavaScript code, the map stays white until there is data to display, see here:

timeout

I have not simulated a complete timeout ( so that there will be no data returned at all), but I guess then the map will stay white forever ...

What would be your preferred behavior in this case?

JakobMiksch commented 8 months ago

@dr-jts I pulled the latest commits from master and it still works as expected.

dr-jts commented 1 week ago

I prefer not to complicate the client code too much. It's really just for demo purposes. Most users will build their own client interface.

JakobMiksch commented 1 week ago

Alright, I understand. Then I am closing this PR.