search

CruxFramework / crux-widgets

6 stars 4 forks source link

Faces Menu should set the stylename instead of appending #592

Closed admtriggo closed 9 years ago

admtriggo commented 9 years ago

From samuel@cruxframework.org on February 02, 2015 16:01:21

Faces Menu property "styleName" is appending the name in the final result:

org.cruxframework.crux.smartfaces.rebind.menu.MenuFactory.MenuItemProcessor.setItemAttributes(SourcePrinter, MenuContext, String)

String styleName = context.readChildProperty("styleName"); if (!StringUtils.isEmpty(styleName)) { styleName = getWidgetCreator().getResourceAccessExpression(styleName); out.println(item + ".addClassName(" + EscapeUtils.quote(styleName) + ");"); }

...

Instead of addClassName, we have to SET the style name using the setClassName.

Original issue: http://code.google.com/p/crux-framework/issues/detail?id=592

admtriggo commented 9 years ago

From juli...@cruxframework.org on February 02, 2015 10:23:50

Labels: TargetVersion-5.3.0

admtriggo commented 9 years ago

From samuel@cruxframework.org on February 03, 2015 05:27:36

fixed on branch 5.3 revision 5903

Status: Fixed
Owner: samuel@cruxframework.org
Labels: Milestone-M14-C5