Crylia / crylia-theme

A theme for AwesomeWM
516 stars 26 forks source link

make both installer backup configs #43

Closed Toni500github closed 1 year ago

Toni500github commented 1 year ago

made this PR so that the installer backup configs if those exists already. Plus it creates a directory on the home and all the programs that we are going to git clone are there

and made some adjust

Toni500github commented 1 year ago

Thanks for the PR, could you address the commend and also adjust the Arch install script? Would be weird with two different behavior's. Thanks

OH right xd, right away when I go home

Crylia commented 1 year ago

Thanks for the changes!

Toni500github commented 1 year ago

no problem

Toni500github commented 1 year ago

The kitty config it's still on the develop branch @Crylia

Crylia commented 1 year ago

changed it, thanks for the reminder

Toni500github commented 1 year ago

lol 69 commits now, nice

Toni500github commented 1 year ago

Hi @Crylia, sorry for ping again, but there something I wanna suggest. i noticed that on the README there is a lot of alacritty and even screenshots with the one that was popular on r/unixporn.

My suggestion it's: isn't it better to just adding something that checks if either alacritty or rust/cargo are installed and tells the user to install those for then copying the config of it , instead of using rofi and changing everything?

Crylia commented 1 year ago

Hi @Crylia, sorry for ping again, but there something I wanna suggest. i noticed that on the README there is a lot of alacritty and even screenshots with the one that was popular on r/unixporn.

My suggestion it's: isn't it better to just adding something that checks if either alacritty or rust/cargo are installed and tells the user to install those for then copying the config of it , instead of using rofi and changing everything?

If you want you can do that, I'm currently rather busy so I won't really do that. I plan on redoing the entire readme in my dev-branch in the near/far future once I'm done with the new config. So keep that in mind (but this branch will be still available)