Cryolian / pe

0 stars 0 forks source link

Incorrect splits when payer is entered as a payee. #8

Open Cryolian opened 6 months ago

Cryolian commented 6 months ago

The program does not account for the payees not being able to be the same person as the payer. This results in an incorrect splitting of expenses.

To recreate the bug, use the member who is paying again under the /user tag.

image.png

soc-pe-bot commented 6 months ago

Team's Response

Accepted as a missing error handling when the same member is added as both payer and payee as the product should throw an error message when the user inputs the same name as payer and payee.

This bug is a duplicate of #1422 where the payer and payee names are the same which results in a missing error handling.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Multiple same member in expense command

image.png Accidentally put in my friend "adarsh s" multiple times in the groupname but no error handling occurred image.png


[original: nus-cs2113-AY2324S2/pe-interim#1689] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted as a missing error handling when the same member is added as both payer and payee as the product should throw an error message when the user inputs the same name as payer and payee.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]