chore: drop kitkat support

Crypho / cordova-plugin-secure-storage

Secure storage plugin for Apache Cordova

MIT License

278 stars 269 forks source link

chore: drop kitkat support #152

Closed demetris-manikas closed 6 years ago

demetris-manikas commented 6 years ago

A lot of cleanup. All tests pass. Please test on iOS.

brodycj commented 6 years ago

It looks like AES support is dropped. Can you confirm? If so, doesn't this affect the other platforms? Shouldn't the documentation be updated?
I think this change needs a new major version number due to both dropping old Android version and apparently dropping support for an encryption algorithm (AES). Or am I missing something here?

ggozad commented 6 years ago

It looks like AES support is dropped. Can you confirm? If so, doesn't this affect the other platforms? Shouldn't the documentation be updated?

I haven't had the time to look into this properly but from a quick glance it seems to me that native AES is used for Android now. For iOS this is unnecessary as the native keychain is used. So AES is still used for Android but we do not rely anymore on sjcl for it.

I think this change needs a new major version number due to both dropping old Android version and apparently dropping support for an encryption algorithm (AES). Or am I missing something here?

SecureStorage will be bumped to a major version yes. The current version can be used by folks needing compatibility with older version of android.

demetris-manikas commented 6 years ago

No. AES is not dropped. Usage of sjcl AES that supported KitKat is dropped. Native AES is used for LOLLIPOP and up. the docs will be updated to mention the drop of support for KitKat. new major version will be assigned.

demetris-manikas commented 6 years ago

Can you guys give a minute?

ggozad commented 6 years ago

Thank you very much Demetris, this looks good. I should be able to review and test on Android as well as iOS next week. Could you please update the docs.

Is there someone who can verify tests pass on Windows?

demetris-manikas commented 6 years ago

@brodybits Thanks for your comments. Code updated.

brodycj commented 6 years ago

Thakns @demetris-manikas for the updates and clarification.

I would be happy to give it a try on Windows, probably sometime next week. Please ping me here in case I forget.

ggozad commented 6 years ago

I am good with iOS and the code review. If @brodybits can verify all ok under windows I will merge and release.

demetris-manikas commented 6 years ago

@brodybits Hi. Can you please perform the tests on windows so that we can go on with this? Thanks in advance.

brodycj commented 6 years ago

I will need a few more days, apologies.