search

Crypho / cordova-plugin-secure-storage

Secure storage plugin for Apache Cordova
MIT License
278 stars 269 forks source link

Add typings for plugin #162

Closed jkfb closed 5 years ago

jkfb commented 5 years ago

Added types for TypeScript

demetris-manikas commented 5 years ago

Hi! Thanks for your contribution but I am not sure whether this can be done properly since the interface is unfortunately not common across all platforms. For Android there is an extra function "secureDevice". If strong typing is required then maybe a dummy function should be added for the other platforms. @ggozad What is your opinion on the matter?

ggozad commented 5 years ago

Hey, sorry totally forgot about this. This is fine, would you mind adding the android extras? If this is a problem for ts, let me know and will accept the PR for the common API. I would avoid dummies here.

Mansour-J commented 5 years ago

Is this getting approved? I am using this library with TypeScript, I would appreciate @types or a away to add types for this lib...

Thanks 👍