Issue #13 and "some" more

CrypticSignal / video-quality-metrics

Uses FFmpeg to benchmark video encoders to compare VMAF/SSIM/PSNR with different encoder settings.

MIT License

117 stars 18 forks source link

Issue #13 and "some" more #15

Closed InB4DevOps closed 3 years ago

InB4DevOps commented 3 years ago

This is a big one, apologies for the number of changes :) If you have any questions please ask!

Just noticed that I forgot to change the readme. Will do later and add to this pull request.

InB4DevOps commented 3 years ago

btw: i disabled main.py line 144 # compute_metrics(transcoded_video, output_folder, json_file_path, graph_filename)

where is compute_metrics? :)

CrypticSignal commented 3 years ago

Good job! I have made some minor changes and you hardcoded a filename on line 54 of overview.py instead of using video_path but I have fixed that. I will merge this pull request now.

CrypticSignal commented 3 years ago

where is compute_metrics? :)

I renamed the compute_metrics function to run_libvmaf.