gatherSources() does not work properly with URLs

Crypto-Punkers / resolver-engine

Single API for resolving Solidity artefacts and imports

GNU Lesser General Public License v3.0

32 stars 26 forks source link

gatherSources() does not work properly with URLs #117

Open squadack opened 5 years ago

squadack commented 5 years ago

Due to current usage of path module, gatherSources() removes second slash in URL, e.g. https://github.com/qwer becomes https:/github.com/qwer. This still counts as valid URL for UrlParser, but is not recognised by, for example, GithubResolver as valid link.

squadack commented 5 years ago

current build in PR #116 fails due to this bug