Fix/value error uov mayo

Crypto-TII / CryptographicEstimators

This project gathers and standardize command line scripts to estimate the difficulty of solving hard mathematical problems related to cryptography.

https://estimators.crypto.tii.ae/

GNU General Public License v3.0

34 stars 5 forks source link

Fix/value error uov mayo #174

Closed fmerino21 closed 1 month ago

fmerino21 commented 1 month ago

Description

Minor fix to avoid a value error when n = 1.5 * m in UOV intersection_attack
Check if time < 0 in exhaustive_search to prevent negative values in MAYO direct_attack Specific example: n=45, m=30, q=16, k=9, 0=8

Review process

Check the implementation of the fixes

Pre-approval checklist

[ ] The code builds clean without any errors or warnings
[ ] I've added/updated tests
[ ] I've added/updated documentation if needed

Javierverbel commented 1 month ago

The method expected_number_solutions should be removed from the mayo_problem.py this method doesn't make sense for the estimators of schemes. Same comment for the attribute nsolution.

Instead of raising an error when time <0. We should remove the method and attribute that regard to the number of solutions. Then, we call the build the instance of the MQEstimator inside the direct_attack without parsing the argument nsolutions

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud