search

Crypto-toolbox / bitex

Crypto-currency Exchange API Framework
MIT License
484 stars 136 forks source link

Fix several bittrex API issues #181

Closed firepol closed 6 years ago

firepol commented 6 years ago

Updated based on your feedback, just def wallet(self, *args, currency=None, **kwargs) doesn't convince me enough. I'd like to have *args and **kwargs at the end of the method signature, like this:

def wallet(self, currency=None, *args, **kwargs)

Any reason to put currency between them? It just makes it look inconsistent.

deepbrook commented 6 years ago

Regarding the order of arguments: It's a code-style thing - first come positionals, then keyword arguments.