CryptoBlades / cryptoblades

534 stars 258 forks source link

[Feature] - FE of Team Battles #1933

Closed remocwenn closed 1 year ago

remocwenn commented 1 year ago

Prerequisites

Describe the feature and its requirements

There has already been an issue created for the back end of team fights as well as a pull request for it. https://github.com/CryptoBlades/cryptoblades/pull/1906

There has not yet been an issue for the front end component of team fights. Below is a series of mock up images and descriptions that should direct how the front end should look.

1 What the current adventure mode looks like

2 There should be an option added that allows users to switch between individual and team combats. Adventure indicates an individual combat and team adventure indicates team combat. There should be an indication to which mode the user is in as indicated by the color of the text.

3 4 The text at the top indicating which adventure mode the user is in should remain regardless of which mode the user is in, but the color of the text should change to reflect it.

There should be a team fight button that executes the team fight and also indicates how many characters will be fighting as X/Y, where X represents the number of characters that are paired up against an enemy and Y represents the number of characters in their plaza.

To represent the character in the team battle I used the cards from the garrison, but also included the power and element of the equipped weapon.

There should be icons that are clickable and allow for the individual selection of each enemy for each character and icons that allow for the switching of an enemy for a given character.

5 6 When either initially selecting or switching between enemy targets there should be a side panel that opens from the right with the available enemy options. There should also be a box that appear surrounding an enemy when you hover over it just like the one in traditional combat that surrounds that enemy.

7 8 The team fight button should be executeable regardless of having a full team or not matched with enemies.

9 10 The team fight result modal should be very similar to that of the individual fight modal. The main differences include the total amount of unclaimed SKILL/VALOR is presented, individual fight rolls and XP gained is showed per character.

Is your feature request related to an existing issue? Please describe.

Yes the backend was done in 1905 https://github.com/CryptoBlades/cryptoblades/issues/1905

The pull request is needing to be reviewed at the time of creation https://github.com/CryptoBlades/cryptoblades/pull/1906

Is there anything stopping this feature being completed?

N/A

Describe alternatives you've considered

N/A

Additional context

I put together the mock images trying to use existing images from the app.