Ads placement - Githubissues

CryptoBlades / cryptoblades

533 stars 258 forks source link

Ads placement #734

Closed bilbolPrime closed 2 years ago

bilbolPrime commented 3 years ago

Sometimes ads cover key game components (fight, market) etc..

Also: ads not rendering in combat (I think cuz SPA)

bilbolPrime commented 3 years ago

The ad placement is caused by the dynamic content expanding I believe. And the ads not showing in combat could be due to them being dynamically injected and not their on "document ready".

Seiryia suggested exploring Vue plugin options. Will do that next.

bilbolPrime commented 3 years ago

Will use this plugin (MIT licensed) https://www.npmjs.com/package/vue-google-adsense

adds "vue-google-adsense": "^1.10.1", "vue-script2": "^2.1.0",

bilbolPrime commented 3 years ago