search

CryptoKraken / crypto-kraken-services

MIT License
0 stars 1 forks source link

Pass queryString as an ojbect instead a string to the sign method of the KuCoinSignatureMaker class #89

Closed skubarenko closed 6 years ago

skubarenko commented 6 years ago

Fixes: #84

I've added the qs package to our dependencies for parsing/stringify a query string. This package is already used by the request package: https://github.com/CryptoKraken/crypto-kraken-services/blob/cea75fcedee9f1f715acf2e83b85e2c760a81ce7/package-lock.json#L3426-L3430

Even when we'll to migrate from the request to other isomorphic packages (Axios, SuperAgent) we can continue to use the qs package, because the Axios mentions using this package and the SuperAgent uses it.