search

CryptoMorin / XSeries

Library for cross-version Minecraft Bukkit support and various efficient API methods.
https://www.spigotmc.org/threads/378136/
MIT License
403 stars 126 forks source link

[XMaterial] - Issue #122

Closed PeachesMLG closed 3 years ago

PeachesMLG commented 3 years ago

In the latest version you changed the enum GRASS_PATH to DIRT_PATH to reflect spigot's changes, 

DIRT_PATH(new String[]{"GRASS_PATH"}),

Wouldnt it make more sence to keep the enum name the same and make DIRT_PATH as an alias for compatibility reasons? I store a running total of all blocks on an island in the database and this is causing errors https://imgur.com/6WaSdPm.png

LOOHP commented 3 years ago

I believe having DIRT_PATH with GRASS_PATH being an alias is the way to go. XMaterial always reflect the changes of the latest Minecraft version. Otherwise we will be using legacy 1.12 names.

CryptoMorin commented 3 years ago

And that is why there is a matchXMaterial()