search

CryptoMorin / XSeries

Library for cross-version Minecraft Bukkit support and various efficient API methods.
https://www.spigotmc.org/threads/378136/
MIT License
403 stars 126 forks source link

Improve parsing of Minecraft versions to resolve #145 #146

Closed wouterdedroog closed 2 years ago

wouterdedroog commented 2 years ago

I've added a @ since 8.5.0 in the Javadoc for the parseVersion(String version) method, although I didn't bump the version number yet in the pom.xml.

Tested with the following version strings:

git-Spigot-3d850ec-809c399 (MC: 1.8)
git-Spigot-3d850ec-809c399 (MC: 1.8.2) 
git-Spigot-3d850ec-809c399 (MC: 1.9.4)
git-Spigot-3d850ec-809c399 (MC: 1.11.2)
git-Spigot-3d850ec-809c399 (MC: 1.12.2)
git-Spigot-3d850ec-809c399 (MC: 1.18 Pre-release 5)
git-Spigot-3d850ec-809c399 (MC: 1.18.2 Pre-release 5)
git-Spigot-3d850ec-809c399 (MC: 1.19)
CryptoMorin commented 2 years ago

Looks great thanks.