CryptoMorin / XSeries

Library for cross-version Minecraft Bukkit support and various efficient API methods.
https://www.spigotmc.org/threads/378136/
MIT License
403 stars 126 forks source link

Serialization for ParticleDisplay #210

Closed HSGamer closed 1 year ago

HSGamer commented 1 year ago

Add a method to serialize ParticleDisplay to a ConfigurationSection.

Also add missing getters for particle, count & extra

CryptoMorin commented 1 year ago

I'm assuming you forgot about this, so I'm bumping it.

HSGamer commented 1 year ago

I'm assuming you forgot about this, so I'm bumping it.

It's pretty much completed. Is there anything else?

CryptoMorin commented 1 year ago

I'm assuming you forgot about this, so I'm bumping it.

It's pretty much completed. Is there anything else?

Did you see the review I left above?

HSGamer commented 1 year ago

I'm assuming you forgot about this, so I'm bumping it.

It's pretty much completed. Is there anything else?

Did you see the review I left above?

No, I didn't see any review.

CryptoMorin commented 1 year ago

Huh, are you not able to see the image below here? If not I'll just merge it and fix it myself no worries. (this is just one of them)

image

HSGamer commented 1 year ago

Huh, are you not able to see the image below here? If not I'll just merge it and fix it myself no worries. (this is just one of them)

image

Your review is marked as Pending. You didn't send it, so I didn't see it.

HSGamer commented 1 year ago

Done

CryptoMorin commented 1 year ago

Thank you for taking your time to do this