CryptoPepes / cryptopepes-alpha-test

Alpha testing - issue tracker

0 stars 3 forks source link

Feedback to user when making transactions. #30

Open programmerror opened 6 years ago

programmerror commented 6 years ago

This is an issue to track the UX aspect of buying/selling/transferring/etc.

Many issues come to the same conclusion: the result of a transaction is not visible to the user immediately, creating uncertainty about what happened, and what is currently in progress. This needs improvement.

Affected parts

[ ] Backend API: search/lookups
[x] Frontend: Visual
[x] Frontend: interactions
[ ] Smartcontract: CPEP erc271
[ ] Smartcontract: Cozy auction
[ ] Smartcontract: Sale auction
[ ] Smartcontracts - miscellaneous
[x] Miscellaneous

kitblake commented 6 years ago

Perhaps buttons that trigger a transaction should have a visual differentiation.

kitblake commented 6 years ago

The problem in #22 is not fixed in today's update. When retrieving a Pepe from the auction I get the same "Insufficient balance for transaction" error, while there's plenty of balance.

Note that the send and receive addresses are the same.

programmerror commented 6 years ago

@kitblake Looks like there's two issues in 22; the query system returning the expired auction as non-expired (Fixed in #31 ), and the 0 ETH issue.

It looks like the client is trying to initiate a transaction using the wrong account, resulting in "0 ETH" balance. The left address in metamask doesn't match up with the address provided in the issue description. And instead, reflects the right address, which is the PepeAuctionSale address. Probably a simple mixup somewhere in the code. I'll search for it and fix it for next release :+1: