Open crmn111 opened 6 years ago
We need some sorta cache for the SVGs somewhere along the traject. Is the server currently generating each Pepe on demand?
@kitblake No, it's pulling an already minimized SVG from a datastore. And images are cached per user now, for 20 mins. This short amount of time was chosen because of pepes being subject to change shortly after being born (orphan blocks). Maybe increasing it to 1 year would be good, but conditionally; only if there are enough confirmations.
Ok. Maybe don't cache newborns?
"there are only two hard problems in software development; they are: cache invalidation, naming things, and off-by-one errors." – Toby Speight Dec 14 '15 at 14:44
@dirkjan111 Instead of that gray background with a spinner, it would look better if a default Pepe background image was displayed, which would then be replaced/covered by the SVG once it arrives.
A loading indicator is a very common way to communicate a waiting time .... but it shouldn't be obtrusive, doesn't have to be animated even, we have to experiment with the layout. Using a default Pepe could work as well, faded out to prevent graphical overload .... perhaps in combination with a spinner.
Yeah, maybe a faded Pepe. That would look less empty than the gray.
Each Loading Pepe should give unobtrusive loading indicator (spinner)
Currently each pepe has a grey background. Each Loading Pepe should give unobtrusive loading indicator (spinner).
Affected parts