CryptoSignal / Crypto-Signal

Github.com/CryptoSignal - Trading & Technical Analysis Bot - 4,100+ stars, 1,100+ forks
https://www.linkedin.com/in/AbenezerMamo
MIT License
4.84k stars 1.26k forks source link

Doesn't execute #7

Closed c931812 closed 6 years ago

c931812 commented 6 years ago

python app.py

Traceback (most recent call last): File "app.py", line 9, in secrets = json.load(secrets_file) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/init.py", line 290, in load **kw) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/init.py", line 338, in loads return _default_decoder.decode(s) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 365, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 381, in raw_decode obj, end = self.scan_once(s, idx) ValueError: Expecting property name: line 4 column 1 (char 117)

Could you please advise, thnx

tsluder8 commented 6 years ago

Did you "Add a secrets.json file to the root directory of your project."?
Removing the twilio lines if you are not using them?

c931812 commented 6 years ago

I did it, my file looks like this

{ "bittrex_key" : "BITTREX_API_KEY", "bittrex_secret" : "BITTREX_SECRET", }

zemelax commented 6 years ago

python app.py

Traceback (most recent call last): File "app.py", line 9, in secrets = json.load(secrets_file) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/init.py", line 268, in load **kw) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/init.py", line 318, in loads return _default_decoder.decode(s) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 343, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 359, in raw_decode obj, end = self.scan_once(s, idx) ValueError: Expecting property name: line 7 column 1 (char 132)

zemelax commented 6 years ago

this is my problem

ghost commented 6 years ago

The problem is at the top of the call stack. Your json file doesn't have the right API keys plugged in. Like the suggestion above, you need to set the following:

{ "bittrex_key" : "BITTREX_API_KEY", "bittrex_secret" : "BITTREX_SECRET", }

c931812 commented 6 years ago

It does but I just didn't post them on github :)

numli commented 6 years ago

Is it because you have a comma at the end of your last KVP (Which you shouldn't have) Try: { "bittrex_key" : "BITTREX_API_KEY", "bittrex_secret" : "BITTREX_SECRET" }

c931812 commented 6 years ago
Traceback (most recent call last):
  File "app.py", line 9, in <module>
    secrets = json.load(secrets_file)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/__init__.py", line 290, in load
    **kw)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 365, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 381, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Invalid control character at: line 2 column 58 (char 59)

Now I'm getting this after removing the comma

numli commented 6 years ago

Could you paste exactly what you've got now? (without the keys obviously)

c931812 commented 6 years ago
Traceback (most recent call last):
  File "app.py", line 1, in <module>
    from bittrex import Bittrex
  File "/../crypto-signal-master/bittrex.py", line 18, in <module>
    import requests
ImportError: No module named requests
numli commented 6 years ago

Have you set up your python environment with all the modules stated in the requirements.txt?

c931812 commented 6 years ago

Yes.

numli commented 6 years ago

the error suggests that you have not got the requests module running properly in your environment or it's running under a slightly different name?

nuieskater commented 6 years ago

This happen to me

nimraMalik commented 6 years ago

where is that secret.json file??

ghost commented 6 years ago

You'll have to create the secret.json file. The issues you guys are running into are simple, I promise. You just have to make sure all the required modules are downloaded. You should the guide in the main README within this repo for installation