Cryptofonts / cryptofont

Cryptocurrency icon webfont and SVG
https://www.cryptofonts.com
GNU General Public License v3.0
177 stars 23 forks source link

replace unsupported cssnano with clean-css #22

Closed edmund-oconnell closed 1 year ago

edmund-oconnell commented 1 year ago

Problem

  1. There is a security vulnerability in js-yaml-3.7.0 (see snyk db details here) which ultimately lives in the dependency chain of cssnano-cli.
  2. CSSNano seems to be largely unsupported. From this article the author summarises

Solution

The solution proposed is to swap out css-nano for clean-css. This package has 12m+ weekly downloads and is fully supported. More importantly it contains no vulnerable packages in its dependency chain

monzanifabio commented 1 year ago

cssnano was previously replaced by @kaimi- with csso (see https://github.com/monzanifabio/cryptofont/pull/21) Is there any benefit in having clean-css over csso?

edmund-oconnell commented 1 year ago

cssnano was previously replaced by @kaimi- with csso (see #21) Is there any benefit in having clean-css over csso?

No. The main thing was to address the vulnerabilities in the dependency chain of cssnano-cli. Looks like this is in hand so closing this PR.

monzanifabio commented 1 year ago

Thanks for your contribution :)