Cryptolens / SKGL

A very simple to use licensing system for .NET applications
https://help.cryptolens.io/faq/what-is-skgl
BSD 3-Clause "New" or "Revised" License
105 stars 36 forks source link

SKGLPlus Hopelessly broken #6

Open lordofscripts opened 3 years ago

lordofscripts commented 3 years ago

I suppose the code is a mess (many classes in one file) because it was transported from CodePlex, but it would have looked much better if separated.

However, I tried it and it is hopelessly broken (The SKGLPlus), I had Generate throw an exception because one method was getting the license key with dashes and it crapped out because it did not expect dashes. Validating the same code given by Generated also says it is an invalid license, that is expired and all that was not true.

Additionally, the scheme is weak too, there is no such thing as an 8-byte hash, a hash is cryptographic algorithm and of all those listed in security sites, none has 8 bytes. There are checksums that are around that size though. Also, the code that attempts to generate such a "hash" is more like security by obscurity than anything else.

More examples or tests would have been nice, but then again, it is broken :( so I don't know why it is here.