search

Crystal-Nest / harvest-with-ease

Don't break crops, right click them!
https://modrinth.com/mod/harvest-with-ease
GNU General Public License v3.0
5 stars 1 forks source link

[Bug] plugin ignores a block require_tool setting as well as the need_[x]_tool.json tag entry. #1

Closed Terminal-Access closed 2 years ago

Terminal-Access commented 2 years ago

Describe the bug It appears that the mod dosent check to see if a block is configured to require a tool or requite a certain level of tool.

e.g im working on a mod where my crop requires harvesting using a hoe and the minie level for that tool is set to diamon or above. this works perfectly untill you right click when this mod is active. it allows you to break/place the crop ignoring the tool requirement.

I understand the plugin is ment to make harvesting easyer however I beleieve it should still respect block that have either a minig level set, requitre tool set or both.

This should be an easy check by calling the inbuilt ".isToolRequired()" boolean from the blockstate.

To Reproduce load up any mod along side your own that sets crops to require either a tool, or sets a specific minig level, wait for the crop to mature and rightclick to harvest. see the crop get auto replanted and it's product given to the player as a drop.

Expected behavior right clicking with out the required tool/mining level appropriate tool should either cause nothing to happen or should destroy the crop with out providing a loot drop or a seed drop.

System information:

thanks.

Crystal-Spider commented 2 years ago

Hi! Thank you for reporting the bug!
I indeed didn't think of that, I fixed the bug and I will merge and release a new version (2.0.0.1) by tomorrow (25/06/2022).

Terminal-Access commented 2 years ago

Awesome, glad I could assist xD

And thank you for the fast responce and fix!

most appreciated.

Crystal-Spider commented 2 years ago

Issue should be solved in version 2.0.0.1!
I'm closing the issue, reopen it if the issue persists.