search

Crystal-Nest / harvest-with-ease

Don't break crops, right click them!
https://modrinth.com/mod/harvest-with-ease
GNU General Public License v3.0
5 stars 1 forks source link

2 high plants in Simple Farming are harvested incorrectly #26

Closed SimonMeskens closed 1 month ago

SimonMeskens commented 10 months ago

Describe the bug Simple Farming has several two-high plants which are broken.

To Reproduce Harvesting the top doesn't do anything, and harvesting the bottom will result in the top staying where it is, while the bottom gets harvested. Punching the top will then destroy the bottom.

Expected behavior Probably the same as with two-high crops from other mods.

Screenshots image

System information:

Crystal-Spider commented 10 months ago

To speed up my work, could you please provide a list of all the two blocks tall crops?
Thank you in advance, I'd be doing that myself but I'm quite busy lately.

SimonMeskens commented 10 months ago

Sure! These seem to be the ones:

I also tested the grapes and they seem to work fine.

simplefarming:corn
simplefarming:corn_top
simplefarming:kenaf
simplefarming:kenaf_top
simplefarming:sorghum
simplefarming:sorghum_top
SimonMeskens commented 10 months ago

Ah, I found one more (the grapes work differently than everything else):

simplefarming:grape_trunk
simplefarming:grape_trunk_top

These ones you can just disable, since they don't grow crops, the actual crops grow on simplefarming:grapevine, but that block harvests fine.

Crystal-Spider commented 10 months ago

Thank you for your help!
I will most likely tackle this issue by the end of September!

SimonMeskens commented 10 months ago

No problem! I'm not blocked by this issue, thanks for the quick response.

Crystal-Spider commented 8 months ago

I haven't forgotten about this, I'm just more busy then I thought I'd be.
I will soon start working on it!

Crystal-Spider commented 8 months ago

So, I looked more into this issue and it seems there's not much I can do.
Simple Farming would need to change how its tall crops are coded to resemble more other mods like Supplementaries and Immersive Engineering, otherwise I would need to create hard-coded features just for Simple Farming, but that would go against this mod being general.

I am opening another issue on Simple Farming GitHub on your and my behalf.

Crystal-Spider commented 1 month ago

Since v9.0.0.3-beta it's possible to add either a configuration option or a datapack to blacklist certain crops from interacting with this mod.
This can "solve" any incompatibility by blacklisting the crops that do not work.
Still, to add proper compatibility, the other mod would need to implement HWE events.

Closing this for now.