search

Crystal-Nest / harvest-with-ease

Don't break crops, right click them!
https://modrinth.com/mod/harvest-with-ease
GNU General Public License v3.0
5 stars 1 forks source link

Bug neoforge networking #39

Closed kittech0 closed 9 months ago

kittech0 commented 10 months ago

Describe the bug Not compatible with latest neoforge version (20.4.142-beta) with networking

Screenshots obraz

Stacktrace and logs https://gist.github.com/NeoCamelot/6b30b7fb7861991ac0eadbcafb0a3ed3

Crystal-Spider commented 10 months ago

Thanks for the report, I'll try to fix it as soon as I can, but I'm currently very busy with a lot of other stuff.
In the mean time, is it strictly necessary to play on the latest NeoForge build? You could try lowering the version until it works again for the time being.

kittech0 commented 10 months ago

just wanted to test out neoforge

Mrbysco commented 10 months ago

Thanks for the report, I'll try to fix it as soon as I can, but I'm currently very busy with a lot of other stuff. In the mean time, is it strictly necessary to play on the latest NeoForge build? You could try lowering the version until it works again for the time being.

SimpleChannel no longer exists past 20.4.70-beta. Was the reason it was registered to have the mod not show a red X when connecting to a server if the client is missing the mod? If so that should already be handled by having displayTest="IGNORE_SERVER_VERSION" in the mods.toml making it safe to remove the SimpleChannel stuff

Mrbysco commented 10 months ago

If desired I could make a PR

Crystal-Spider commented 10 months ago

As you said, the red X comes from the mods.toml property.
However, that only checks whether the mod is installed on the correct sides (in the case of HWE it can be on server and it's optional on the client, it will show the red X only when it's on the client but not on the server). The channel stuff was to check whether the version of the mod on the server is compatible with the optional version on the client, so it can't just be removed.
Anyway, most likely by the end of this week I will have time to fix this, but no promises.

Cheaterc662 commented 9 months ago

Hi i would like to add that the older version of this mod has this same issue Zrzut ekranu 2024-02-08 234429

Crystal-Spider commented 9 months ago

Yeah, all 1.20.4 versions will have the same error because I used an older NeoForge version to build them, thanks for reporting though.

Crystal-Spider commented 9 months ago

Is fixed with v8.0.1.1 (NeoForge only).