Crystal-Nest / torch-hit

Attack with torches!
https://modrinth.com/mod/torch-hit
GNU General Public License v3.0
3 stars 1 forks source link

Fabric 1.21 server hangs on shutdown at "All dimensions are saved" #26

Closed HatTrkPatrk closed 3 months ago

HatTrkPatrk commented 4 months ago

I have confirmed no other issue reports this bug

I have confirmed the mod is installed on the proper side

Current behavior

Sending the "stop" command to the server initiates the shutdown process, saves all the world data, etc. but then the process fails to exit/terminate and must be forcibly terminated (Ctrl-C) in the console.

The last message shown in the server/console log is "ThreadedAnvilChunkStorage: All dimensions are saved". Just to be sure, I waited around 5 minutes (to rule out the possibility that it might've just been taking an excessively long time, for whatever reason) before forcing the process to close.

This occurs with no other mods than the Fabric API (v0.100.7), Forge Config API Port (v21.0.1), Cobweb (v1.1.2), and Torch Hit (v7.0.0) installed on a Fabric 1.21 server, and removing Torch Hit from the mods folder allows the server process to exit properly.

This behavior makes it difficult to e.g. write startup/service scripts on *nix platforms, as the process never exits when shutting said service down.

Expected behavior

Server process should exit properly.

Steps to reproduce

  1. Stage a Fabric 1.21 0.15.11 server.
  2. Add Fabric API, Torch Hit, and its dependencies to the "mods" directory.
  3. Start the server.
  4. After world is finished preparing, send "stop" command to the server console.
  5. Server hangs at "All dimensions are saved" message.

Minecraft version

1.21

Mod loader version

Fabric 0.15.11

Mod version

7.0.0

Other mods

Only the Fabric API, Torch Hit, and its listed dependencies (ForgeConfigAPIPort and Cobweb).

Stacktrace and logs

[13:11:43] [main/INFO]: Loading Minecraft 1.21 with Fabric Loader 0.15.11 [13:11:43] [main/INFO]: Loading 46 mods:

Additional context

No response

Crystal-Spider commented 3 months ago

Could you please update to Fabric 0.16.x and an the latest version of FCAP and let me know if the issue persists?

I couldn't personally replicate the problem even with the same mod setup.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 14 days with no activity. In 14 days it is going to be closed.

github-actions[bot] commented 3 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.