Crystalis7 / Hybrid-Beta

16 stars 2 forks source link

Incompatibility with Deeper Oceans mod/datapack #10

Open FrozenDragon0 opened 1 year ago

FrozenDragon0 commented 1 year ago

Just a small incompatibility with the deeper oceans mod/datapack I found whilst using this:

Deep oceans seems to straight up not work if Hybrid beta is installed resulting in chunk borders if used in a existing world, or no extended deep oceans in a fresh world.

2023-06-01_17 53 07

2023-06-01_17 56 18

Deeper oceans here: https://www.curseforge.com/minecraft/mc-mods/deeper-oceans

Crystalis7 commented 1 year ago

Hello - do these chunk borders occur when using Deep Oceans with other terrain generation datapacks which modify the ocean biomes, for example Terralith?

FrozenDragon0 commented 1 year ago

Just done a test with Terralith and it seems deeper oceans works as expected with Terralith.

Crystalis7 commented 1 year ago

I think that Terralith already makes the oceans deeper, so that is likely why it appears to work. But I expect that the same issue will arise when adding Terralith to an existing world - unless Terralith makes the oceans equally deep as Deeper Oceans, there will likely be the same harsh chunk borders.

I have done some brief testing, and it seems that if you use the datapack versions of both Deeper Oceans (available here) and Hybrid Beta, and you put the Deeper Oceans pack at the top of the datapack list when creating/editing the world, then the Deeper Oceans content will take precedence and will generate the deeper oceans as expected (though there may well be some unexpected bugs/quirks).

In terms of the harsh chunk borders, I would need to investigate further to be sure, but I think that they are caused by a lack of blending support in the Deeper Oceans pack. This would mean that there isn't anything that could be done from my side to prevent them from occurring.