search

Crystalis7 / Hybrid-Beta

14 stars 2 forks source link

No Compatibility With Continents Mod #21

Open mdaole opened 4 months ago

mdaole commented 4 months ago

This mod doesn't have compatibility with the continents mod. https://www.curseforge.com/minecraft/mc-mods/continents Source: https://github.com/Stardust-Labs-MC/Continents

I figured out that it was because of the inclusion of this file https://github.com/Crystalis7/Hybrid-Beta/blob/master/Cascades/data/minecraft/worldgen/density_function/overworld/continents.json which can't get overwritten by the continents mod. Removing it seems to make it work with the continents mod.

Is there a reason for including that file? It doesn't seem to be different from the vanilla file https://github.com/misode/mcmeta/blob/data-json/data/minecraft/worldgen/density_function/overworld/continents.json

I have no experience with data packs or terrain gen modification, I've just been poking around trying to get things to work.

Crystalis7 commented 4 months ago

Thank you for raising this. You are correct in saying that the continents density function file is not required. I was probably experimenting with changing it a while ago but did not delete it once I had finished. I will double-check, and then post a small patch with that file removed.

I am surprised, though, that Continents is not able to override the file - when you say that these two mods are not compatible, do you mean that the game crashes when trying to create a world with both of them, or that a world can be created, but it doesn't look as expected?

mdaole commented 4 months ago

The incompatibility is that continents has no effect on terrain generation when installed. So it's as if it wasn't added in at all. Removing the continents.json file from your datapack allows the two mods to work together properly. You can test this online here: https://map.jacobsjo.eu/

mdaole commented 4 months ago

And thank you! I love the terrain generation your mod creates, it's the only one out of the many that I've tried that brings back that old feeling of minecraft magic.

Maybe this should be added in a separate issue, but would you consider adding in a vanilla only biomes version of your mod? I'd love to include this in a modpack. Your new biomes are nice, but for simplicity and compatibility with other mods it'd be a lot easier if there were only vanilla biomes. I seem to be able to do this by deleting minecraft/dimension/overworld.json, but I wouldn't feel comfortable distributing that in a modpack without your permission.

It's totally understandable if that's not compatible with your vision for this mod though. If so, would it be okay to include this mod in a modpack along with an extra datapack that overrides minecraft/dimension/overworld.json back to vanilla settings?

Crystalis7 commented 4 months ago

Regarding the idea of having a version of the pack with just vanilla biomes, it is not quite as simple as just deleting the customised overworld.json and allowing Minecraft to default to the vanilla one. This does most of the job, but there will be minor misalignments around rivers and oceans (e.g ocean/river biomes encroaching on the land). That being said, if the aim is to increase compatibility with other mods, then it will certainly help.

I will have a think about the feasibility of supporting a vanilla-biomes-only version of the mod. My main concern is opening the doors to having to support many different variants of the pack, which, aside from being confusing to people trying to download it, will be more difficult to maintain. That being said, I think that this may well be an exception. The ideal circumstance would be that Mojang improves the whole datapack system in terms of making them able to be more easily made compatible with one another. But short of that, I think a version of this datapack which does not change the biome system would likely be the best solution.

mdaole commented 4 months ago

Thanks for the explanation! I understand it wouldn't be that simple, and would lead to some maintainability issues for you, so I appreciate you taking the time to think about it.

Crystalis7 commented 3 months ago

Hello - I have gone ahead and published Cascades: Source - a version of this datapack with all of the biome-related content removed. It is available in the Releases page of this repository.

Still deciding whether or not to create a new Modrinth page for it, or to publish it to the same page. I hope that this is useful!

mdaole commented 3 months ago

Wow, that's incredible. Thank you so much! I'm so looking forward to trying this out :)

Crystalis7 commented 3 months ago

Great - I am happy to take any feedback you may have on it