search

Csardelacal / YCH-Issues

Issue tracking for YCH.commishes.com
1 stars 0 forks source link

Multiple duplicate Email notifications for finished auctions #11

Closed Csardelacal closed 8 years ago

Csardelacal commented 8 years ago

The system seems to send out several emails when an auction ends. I've tracked a user who posted 4 auctions and received 6 emails - with their 6 client counterparts.

This is probably due to the file-locking mechanism and it needs to be looked into.

Csardelacal commented 8 years ago

This was due to an issue with the file locking mechanism. We're using the LOCK_NB flag which should have a second parameter $ewouldblock.

The ewouldblock parameter is not very precisely defined in the PHP documentation and seems to be pretty weird. I removed it and the code works fine, but the doc says that it is required.