search

Csson / p5-DBIx-Class-Visualizer

Visualize a DBIx::Class schema using graphviz generated SVG
Other
2 stars 1 forks source link

transform_svg is neat - contribute upstream? Also, try from_graph? #3

Open mohawk2 opened 3 years ago

mohawk2 commented 3 years ago

I was just looking at reverse-deps for GraphViz2 and saw your transform_svg API, which looks quite neat and not very specific to your module. Are you open to me pulling that into GraphViz2 proper (crediting you, obviously)?

Are you aware of the brand-new https://metacpan.org/pod/GraphViz2#from_graph method? It would allow you to construct a https://metacpan.org/pod/Graph object from your underlying data (possibly with an as_graph method/lazy-built attribute), and then you could have a graphvizify function underlying your existing graph method. See https://metacpan.org/pod/GraphViz2::Parse::STT for inspiration if interested - if you're a bit busy but interested, I'll be happy to submit a PR :-)

Csson commented 3 years ago

Hi! Of course, feel free to pluck it if you want :slightly_smiling_face:

I have noticed that things have been changing in GraphViz2, so I should probably try to get up to speed. Good work :+1: