search

CtrlAltFocus / obsidian-plugin-auto-tag

Easily generate relevant tags for your Obsidian notes.
https://twitter.com/ctrl_alt_focus
MIT License
43 stars 6 forks source link

Image embeds may be crashing the plugin #16

Open seantiz opened 7 months ago

seantiz commented 7 months ago

This has proved a very useful plugin so far. The one issue I ran into is a .png embed in a note brought the plugin to crash each time.

In a different note with a .jpg embed (and far less markdown code attached to it) there was no problem. I believe the difference with the .png embed isn't necessarily the format, but that the markdown code in the embed attachment has a LOT more characters in it.

CtrlAltFocus commented 6 months ago

Sorry for not having responded in this topic earlier, I saw the notification via email and noted it.

Haven't had the time to work on this till now. I'll start looking at a fix for this issue this week, while working on ollama localhost/open-source AI support.

seantiz commented 6 months ago

No problem! if could be that i was sending too much for GPT3.5 to tokenise. that's my best guess.

CtrlAltFocus commented 6 months ago

Might be! In that case, still is an issue :-) The plugin should warn about that, and either not allow it, or cut off at the limit or make multiple requests (or let the user decide :) ).