Ctrlpanel-gg / panel

CtrlPanel offers an easy-to-use and free billing solution for all starting and experienced hosting providers that seamlessly integrates with the Pterodactyl panel.
https://ctrlpanel.gg/
MIT License
418 stars 144 forks source link

[Bug]: Free Products Are Suspended Despite Having No Costs #1048

Closed Maximilian1021 closed 5 hours ago

Maximilian1021 commented 20 hours ago

What is your request about?

Description: Products configured as free and requiring no balance are being suspended when the user’s account balance is 0 Coins. This occurs even though the products are correctly set up as free (see attached screenshots). However, if the user has a small balance (e.g., 0.005 Coins), the products are not suspended, and previously suspended products are automatically reactivated by the system.

Steps to Reproduce:

Configure a product as free, requiring no account balance.
Create a user account with a balance of 0 Coins.
Observe that the server is automatically suspended after a while, despite the product having no costs.
Add a minimal amount of Coins (e.g., 0.005 Coins) to the user’s account.
Observe that suspended products are reactivated and no further suspensions occur.

Expected Behavior: Free products should not be suspended regardless of the user’s account balance, as they incur no costs.

Actual Behavior:

Products are suspended when the user’s balance is 0 Coins after some time.
With a balance of 0.005 Coins or higher, products remain active, and previously suspended products are reactivated.

Screenshots

Server Overview Log Produkt

Branch

development

Solution idea

I am not familiar with programming. That's why I'm not going to suggest a solution here. The problem seems to be related to the validation of the credit amount in the system, even if the product is explicitly configured as free.

Ctrlpanel Logs

Nothing visible in the logs

Additional Info

No response

1day2die commented 20 hours ago

https://github.com/Ctrlpanel-gg/panel/pull/1043

1day2die commented 20 hours ago

the fix needs testing by someone

Maximilian1021 commented 18 hours ago

grafik grafik Same after patch

S0ly commented 17 hours ago

not fixed

IceToast commented 14 hours ago

grafik grafik Same after patch

Did you reproduce the bug or did you want the fix applies to already suspended free servers too?

Maximilian1021 commented 5 hours ago

Mistake on my part. Someone has interfered!