Ctrlpanel-gg / panel

CtrlPanel offers an easy-to-use and free billing solution for all starting and experienced hosting providers that seamlessly integrates with the Pterodactyl panel.
https://ctrlpanel.gg/
MIT License
418 stars 145 forks source link

[feature] Payment Gateway handling fees #351

Open anondev-sudo opened 2 years ago

anondev-sudo commented 2 years ago

🚀 Feature Request

Is your proposal related to a problem?

Provide a clear and concise description of what the problem is. For example, "I can't change x and it makes me have to do manual work"

I use tax to cover payment gateway provider fees. Paypal and Stripe don't have the same fees so it's unfair to have the same tax for both gateways.

Describe the solution you'd like

Provide a clear and concise description of what you want to happen. For Example, "Automate the changing of x so I don't have to do it manually"

Add config option in admin area to set different tax for every payment gateway.

Better Alternative: It would be nice it option to set handling fee in % per payment gateway would be added in configuration tab. The handling should be added as second item to invoice (on checkout page, payment gateway and on pdf invoice)

Additional context

Is there anything else you can add about the proposal? You might want to link to related issues here, if you haven't already.

https://github.com/ControlPanel-gg/dashboard/issues/290#issuecomment-1001627783

IceToast commented 2 years ago

You mean a fee set for a specific payment gateway correct? This has nothing to do with taxes, as taxes have nothing to do with the payment gateway but the country you are handling your payments in

anondev-sudo commented 2 years ago

I want to set different tax in % for Paypal and for Stripe. I use tax to cover payment gateway fees as currenctly there is no option to add Payment Gateway handling in %.

IceToast commented 2 years ago

Did you overread my comment maybe?

Why would you add a TAX for a specific payment gateway? Taxes are regulated by law at your country. What you are talking about is a fee for a payment gateway (the cut paypal or stripe takes from each payment).

anondev-sudo commented 2 years ago

I use tax to cover payment gateway fees as currenctly there is no option to set Payment Gateway handling fee in %.

Add option to set handling fee in % per Payment Gateway.

IceToast commented 2 years ago

I use tax to cover payment gateway fees as currenctly there is no option to set Payment Gateway handling fee in %.

Add option to set handling fee in % per Payment Gateway.

Yes, thats exactly what i said in my first comment. It's not a tax it's a fee. Thats much different ^^

Anyways i would like to ask you to be a little more polite to the contributors at cp.gg. It's not motivating to have someone say "Do this, do that".

anondev-sudo commented 2 years ago

I wanted per payment gateway tax setting because my suggestion to add handling fee option was closed here https://github.com/ControlPanel-gg/dashboard/issues/290#issuecomment-1001627783

most likely wont do that. just add this procentage to the tax, adjust your product prices or deal with the fees^^ <3

I was told here to use tax for this purpose.

1day2die commented 2 years ago

Because for now we have different priorities. If a contributor decides to code that we can reopen that issue

IceToast commented 2 years ago

I wanted per payment gateway tax setting because my suggestion to add handling fee option was closed here #290 (comment)

most likely wont do that. just add this procentage to the tax, adjust your product prices or deal with the fees^^ <3

I was told here to use tax for this purpose.

Your issue #290 was about adding a custom item to the checkout which can be interpreted as user customizable. Which is much different to a fixed (percentage can be set by user) item that does not need to be customized in any way by the value...

Edit: Dont worry, this will be added someday ^^ Was just telling this is a fee, not a tax.

anondev-sudo commented 2 years ago

Maybe there could be just option on the payment gateways settings to set custom fixed fee + fee in % per gateway (as not all gateways have the same fees). It should be displayed as Payment Gateway handling fee on the invoice/order confirmation. Or there could be option to add custom item to checkout (also with settings to set it only for some gateway(s), product(s), the item price could be in % - based on the current order amount or fixed price), this would be the most customisable to serve all needs of users.

IceToast commented 2 years ago

The first description would fixes the problem the best. That's also how i would implement it.

S0ly commented 1 week ago

@1day2die have this been done ?

MrWeez commented 1 week ago

@1day2die have this been done ?

As far as I know, no