search

Ctrlpanel-gg / panel

CtrlPanel offers an easy-to-use and free billing solution for all starting and experienced hosting providers that seamlessly integrates with the Pterodactyl panel.
https://ctrlpanel.gg/
MIT License
395 stars 142 forks source link

Correction of the inability to translate some fields into other languages #866

Closed MrWeez closed 1 year ago

MrWeez commented 1 year ago

You're forgetting some translations

Thanks, I didn't notice right away. Fixed.

MrWeez commented 1 year ago

Incorrect syntax, I'll fix it now

MrWeez commented 1 year ago

Incorrect syntax, I'll fix it now

Although no, that's right. I just checked the code on the panel from the main branch, forgetting that the changes were made in development

MrWeez commented 1 year ago

Not sure if you've added the translations to their language files yet, otherwise looks good to me.

I could upload the localization file of my panel (ru.json), but there are a lot of localized translation moments

AGuyNamedJens commented 1 year ago

Not sure if you've added the translations to their language files yet, otherwise looks good to me.

I could upload the localization file of my panel (ru.json), but there are a lot of localized translation moments

https://github.com/Ctrlpanel-gg/panel/blob/development/lang just add the variables to these files, use google translate if you don't know all language variants for them.

MrWeez commented 1 year ago

I am not responsible for the accuracy of the translation, but I seem to have added it everywhere)

AGuyNamedJens commented 1 year ago

I am not responsible for the accuracy of the translation, but I seem to have added it everywhere)

That's fine, whenever people feel like somethings wrong in their language they can submit a PR as well. It's better to include them whenever you do language changes due to them otherwise defaulting to english / fail to translate when it's missing, would look weird to see random english with russian as language selection lol.

MrWeez commented 1 year ago

After the release of 0.10, I will most likely completely rework the Russian language, since now it looks very illiterate and at times it is not correct at all.

AGuyNamedJens commented 1 year ago

After the release of 0.10, I will most likely completely rework the Russian language, since now it looks very illiterate and at times it is not correct at all.

Sounds logical, as the current contributors don't speak Russian, lol.

MrWeez commented 1 year ago

After the release of 0.10, I will most likely completely rework the Russian language, since now it looks very illiterate and at times it is not correct at all.

Sounds logical, as the current contributors don't speak Russian, lol.

In fact, there are a lot of Russian people, it's just that many do not know English at a sufficient level.

IceToast commented 1 year ago

Some conflicts need to be resolved, can be merged when they are