search

Ctrlpanel-gg / panel

CtrlPanel offers an easy-to-use and free billing solution for all starting and experienced hosting providers that seamlessly integrates with the Pterodactyl panel.
https://ctrlpanel.gg/
MIT License
390 stars 141 forks source link

feat: Add readable name to permissions #910

Open Ferks-FK opened 9 months ago

Ferks-FK commented 9 months ago

Add friendly names for role permissions.

This needs a refactoring of the way permissions are checked on controllers.

S0ly commented 1 month ago

is this still up to date ?

S0ly commented 1 month ago

I cant resolve the conflict and I cant determine the priority of this feature

1day2die commented 1 month ago

I cant resolve the conflict and I cant determine the priority of this feature

its a huge step for user friendliness

S0ly commented 1 month ago

so its a medium or high priority ?

1day2die commented 1 month ago

should be resolved?

1day2die commented 1 month ago

not tested at all

1day2die commented 1 month ago

so its a medium or high priority ?

medium

S0ly commented 1 month ago

and what need to be done for it to be merged ?

1day2die commented 1 month ago

@Ferks-FK

S0ly commented 1 month ago

ferk told me on discord that he didnt remembered :(

Ferks-FK commented 1 month ago

and what need to be done for it to be merged ?

I think my original plan was to use laravel Policies on the controller side

S0ly commented 1 month ago

so what we do of this PR ? @Ferks-FK will you finish it ? what is it used for because the description is very vague

Ferks-FK commented 1 month ago

so what we do of this PR ? @Ferks-FK will you finish it ? what is it used for because the description is very vague

It can be merged as it is (needs testing), taking into account that the development branch needs to be tested as a whole.

S0ly commented 3 weeks ago

@Ferks-FK im confused by the files, can you more explain what is going on what are the change and what they do ? and deactivate the draft mode of the PR if you think it can be merged thanks !

S0ly commented 3 weeks ago

any news ?

Ferks-FK commented 3 weeks ago

@Ferks-FK im confused by the files, can you more explain what is going on what are the change and what they do ? and deactivate the draft mode of the PR if you think it can be merged thanks !

I commented that this would need a refactoring in the way permissions are checked in the backend, but this can easily be done in another PR, because it would take a lot of changes. So I'll open this PR, and it could be merged.

S0ly commented 3 weeks ago

okay @IceToast need you :)

S0ly commented 2 weeks ago

why you don't merge it ? :)

IceToast commented 2 weeks ago

This PR has conflicts with development. @Ferks-FK can you fix them in order to merge the PR?