search

Ctrlpanel-gg / panel

CtrlPanel offers an easy-to-use and free billing solution for all starting and experienced hosting providers that seamlessly integrates with the Pterodactyl panel.
https://ctrlpanel.gg/
MIT License
410 stars 147 forks source link

feat: 2FA Progress Sync #920

Closed AGuyNamedJens closed 2 months ago

AGuyNamedJens commented 9 months ago

Managed to get 2FA integration working, it yet has to be connected to the actual login method for users. Feel free to debug, change it or whatever. Basics are implemented.

See: app/Http/Controllers/Auth/Login2FAController.php app/Http/Controllers/LoginCheckpointController.php app/Http/Controllers/Kernel.php app/Http/Models/RecoveryToken.php app/Http/Models/User.php database/UserFactory.php routes/web.php themes/default/views/auth/2fa-secret.blade.php composer.json

For my changes

GeekCornerGH commented 9 months ago

How would it links to ptero 2fa?

AGuyNamedJens commented 9 months ago

How would it links to ptero 2fa?

I don't have enough knowledge about how Pterodactyl does it, I honestly don't think we can just hook into their 2FA system because that can basically beat the whole security logic of 2FA

sybetjeh commented 9 months ago

How would it links to ptero 2fa?

I don't have enough knowledge about how Pterodactyl does it, I honestly don't think we can just hook into their 2FA system because that can basically beat the whole security logic of 2FA

yeah please don't what would the point be then?

S0ly commented 5 months ago

no update since 2023 ?

AGuyNamedJens commented 5 months ago

no update since 2023 ?

Feel free to provide your own update, I'm clueless at this point which is why I request other contributions to join in

S0ly commented 4 months ago

I tried to resolve the conflict that was whit .gitignore hope I didnt missed anything

S0ly commented 3 months ago

what we do of this pull request since its totally inactive and not finished ?

S0ly commented 3 months ago

@IceToast @1day2die

AGuyNamedJens commented 3 months ago

what we do of this pull request since its totally inactive and not finished ?

I guess no one wants it implemented? I got stuck at the moment of login methods, as previously discussed it's due to how we still depend on Laravel/ui which makes integration impossible with 2FA

S0ly commented 3 months ago

personally it would be interesting me to have this but its not currently on my priority list :) and I dont know how to help whit it

S0ly commented 2 months ago

we should close the PR if no one is gonna do it, it will be available for reopen later

AGuyNamedJens commented 2 months ago

we should close the PR if no one is gonna do it, it will be available for reopen later

I agree.