search

Ctrlpanel-gg / panel

CtrlPanel offers an easy-to-use and free billing solution for all starting and experienced hosting providers that seamlessly integrates with the Pterodactyl panel.
https://ctrlpanel.gg/
MIT License
390 stars 141 forks source link

[Bug]: Verbiage on register a new membership screen #927

Closed purejosh closed 3 months ago

purejosh commented 5 months ago

What is your request about?

When registering a new membership and using an email that's already in use, it says the following: image

Branch

main

Solution idea

Recommend not mentioning Pterodactyl, and also changing the second part. Account already exists, please contact Support. Maybe include which detail is duplicate, such as username or email.

Controlpanel Logs

No response

Additional Info

No response

purejosh commented 5 months ago

Another improvement: image Recommend changing to:

Email verification required!
You must verify your email address before proceeding. Click here to resend verification email!
Please contact support if you do not receive your verification email.
MrWeez commented 5 months ago

Good afternoon. If you have problems with the installation, please create a forum post in the support channel on our Discord server.

purejosh commented 5 months ago

I never used the word install anywhere in my post. Not sure where you got that from.

MrWeez commented 5 months ago

I'm sorry, it seemed to me that you had problems registering 😅

purejosh commented 5 months ago

No, all good there. Just providing feedback for improving the english used in the panel.

MrWeez commented 5 months ago

What is your request about?

When registering a new membership and using an email that's already in use, it says the following: image

Branch

main

Solution idea

Recommend not mentioning Pterodactyl, and also changing the second part. Account already exists, please contact Support. Maybe include which detail is duplicate, such as username or email.

Controlpanel Logs

No response

Additional Info

No response

I don't think there is an error here, because when registering with the same email that already exists in Pterodactyl, an error appears in the API response. Also, if the user has an account in pterodactyl, but not in cpgg, the same text will be displayed

MrWeez commented 5 months ago

Another improvement: image Recommend changing to:

Email verification required!
You must verify your email address before proceeding. Click here to resend verification email!
Please contact support if you do not receive your verification email.

The message should be universal, as you can make email verification optional. Also, if necessary, you can change this text yourself, in the language files that are located in the lang folder

purejosh commented 5 months ago

I don't think there is an error here, because when registering with the same email that already exists in Pterodactyl, an error appears in the API response. Also, if the user has an account in pterodactyl, but not in cpgg, the same text will be displayed

There is no bug. This github was opened to give you more clear verbiage to use for those two sections. They're worded poorly, that is all.

1day2die commented 5 months ago

Thanks man. Instead of opening an issue you could also just edit the files here on github and make a pull request! :)

I will keep this in my head unless someone else decides to fix the wording

purejosh commented 5 months ago

Sorry, I should've thought that way too, but I assumed this would be a quick and easy feedback. Now that we're here, yeah, it would've made more sense to submit a PR.

In my defense, I have no idea how PHP works. So I'd have to heavily rely on search to find anything.

Are all these various texts located in the lang?

1day2die commented 3 months ago

hi,

yeah, all these can be changed in the lang/en.json file.

Feel free to make an edit to those :)