Closed kenshin133 closed 1 month ago
Please don’t forget to correctly configure your PR
Is this PR ready for review or you forgot to put it in draft mode ?
And don’t make commit that long 😂 add a comment here if needed
But other than that it’s fine :) thanks for the fix !
Sorry, thought that was for the pull, I dont see a way to edit it, the code is ready.
Thank you kindly for reviewing.
Don’t worry you seems new :D and we don’t have good contributing guidelines for the moment
For me the change seems fine but I would like someone else to check it since I’m confused by what need to be shown
Don’t worry you seems new :D and we don’t have good contributing guidelines for the moment
For me the change seems fine but I would like someone else to check it since I’m confused by what need to be shown
I'll check it out when I get home.
Thanks tell me if it’s good ;)
Thanks tell me if it’s good ;)
Yep, everything works. You can merge this PR
This seems to be referenced two places, admin/servers and admin/users/1
I could not find any other effects of this change but do feel free to double check my work.
themes/default/views/admin/servers/table.blade.php And themes/default/views/admin/users/show.blade.php and perhaps themes/default/views/admin/users/edit.blade.php
have data: 'resources', name: 'product.name',
In them, another fix would be to alter this to data: 'product.name' but the proposed change seems like the right one.